Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix image reader navigation (tablet) #329

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

aaronleopold
Copy link
Collaborator

Resolves (hopefully) #328

I've adjusted the reader to be more programmatic and less CSS-centric for computing the navigation tap boundaries:

  • If the loaded image is >= 80% of the width of the viewport, the navigation divs will be fixed to the left/right with a fixed 10% width
  • If the loaded image is < 80%, the navigation divs will be inline left/right to the image and fill any available space

I've also added swipe handlers on mobile viewport sizes. I tested this on an iPad mini, and then a few other tablet sizes in my dev tools.

@aaronleopold aaronleopold merged commit abb00de into develop Apr 28, 2024
3 checks passed
@aaronleopold aaronleopold deleted the al/fix-tablet-image-reading branch April 28, 2024 20:21
@aaronleopold aaronleopold mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant